Add support for ipv6 target groups #752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudFormation library https://github.com/mweagle/go-cloudformation was last updated in October 2021 and recommends to use https://github.com/awslabs/goformation which is archived since October 2024. This change vendors in this dependency to enable addition of new missing CloudFormation features. * clone github.com/mweagle/go-cloudformation into aws/cloudformation * remove unused aws/cloudformation/deploycfn * replace imports Updates #459 Signed-off-by: Alexander Yastrebov <[email protected]>
Signed-off-by: Alexander Yastrebov <[email protected]>
Signed-off-by: Alexander Yastrebov <[email protected]>
Signed-off-by: Alexander Yastrebov <[email protected]>
Signed-off-by: Alexander Yastrebov <[email protected]>
Signed-off-by: Alexander Yastrebov <[email protected]>
Signed-off-by: Alexander Yastrebov <[email protected]>
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
This was referenced Jul 18, 2025
Contributor
Author
|
We need the load balancer ip address type to be dual stack so that we can add ipv6 target groups. See error message from cf stack |
added 4 commits
July 18, 2025 12:53
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
ayruslore
changed the title
added 9 commits
July 25, 2025 17:34
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
Signed-off-by: speruri <[email protected]>
Contributor
Author
|
Closing in favour of #763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ipv6 target groups.
Also bases the changes from #751
The PRs on k8s-on-aws zalando-incubator/kubernetes-on-aws#9627 and zalando-incubator/kubernetes-on-aws#9637