Remove %BIN_DIR fake plugin entry from zinit times output.
#434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psprint
requested review from
alichtman,
pschmitt and
vladdoster
as code owners
vladdoster
requested changes
Dec 2, 2022
psprint
force-pushed
the
Mute-BIN_DIR-plugin
branch
from
23f0619 to
4f1a62a
Compare
|
@vladdoster: I've renamed the commit adding "fix:" prefix. |
|
Is anything wrong with PR? It's quite important to get this active as the fake absolute path plugin may be confusing users and is not nice to leave there dangling… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fake
%$ZINIT[BIN_DIR]plugin shouldn't be shown inzinit timesoutput.Motivation and Context
The fake
nullplugin is used to autoload a function from BIN_DIR zinit directory, it shouldn't be listed.Related Issue(s)
#426
How Has This Been Tested?
It is a straightforward change, however I've tested it via
zinit timesand everything was OK.Types of changes
Checklist: