Look in parent directories for btest.cfg

[evantypanski]

1. Makes btest consider more than just the current directory when looking for the config file - it will now look in parent directories until it finds it
2. Allows relative paths in the absence of a valid test
3. Allows running the tests from outside of the test suite (eg btest zeek/testing/btest/language/while.zeek)

There are a couple edge cases I'll check tomorrow-or-so, therefore this is a draft. And the failing test is a little sad (where it finds the parent's btest config even though it should fail), may need a different config file name so that it doesn't clash with the test suite's btest config.

[evantypanski]

I updated it to make sure dots work from relative directories, but that specifies the test exactly. So the dot syntax should stay the same, where you can't specify a "relative" test with dots.

I think the edge cases are mostly covered too, dots seem to work the same and I think temp directories don't change since they cd to the test base anyway. It just changes 2 places files are found.

[awelzel]

Suggest to get another approval from @bbannier or @rsmmr.

Comments are mostly nitpickery, though it'd be nice to have the special case for the test base directory imo.

[rsmmr]

There are cases where we don't abort if not finding a btest.cfg:

# pwd
/Users/robin/work/zeek/master/auxil/btest/testing
# ../btest /etc
/etc/manpaths: mandatory keyword '@TEST-EXEC' or '@TEST-EXEC-FAIL' is missing..

One question: Once we have found btest.cfg, is the current working directory then consistently set to where it's located, independent from where btest was called? Is should, and from a quick test, I couldn't find a counter example; but from the code, I wasn't really sure.

[evantypanski]

is the current working directory then consistently set to where it's located, independent from where btest was called?

I believe so, it changes to the directory that the config file was found in. That's (thankfully) why all of the temp files and directories in the config just magically worked with this change. Seems like that's necessary for when a different config file is passed in, even before this change, so the machinery was there.

There are cases where we don't abort if not finding a btest.cfg

Seems like btest also lets you execute ignored files as tests, it just adds them if it doesn't already know about them and you passed a file in. I personally would rather that case just error, but maybe it has some use?

[rsmmr]

Ok, so approving, I don't want to hold this up on the rare/impossible case of multiple configs. If you can easily make that one change of finding all configs, I'd still prefer that, otherwise fine as is.

[evantypanski]

For the test I had to update the diff-remove-abspath script (or it combined the two paths...). That was roughly from Zeek's (with modification).

This seems to be the consensus behavior, minus style nits