Skip interpolation checks for non-selected alternative sections #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelzel
force-pushed
the
topic/awelzel/122-skip-non-selected-environment-interpolation
branch
from
8da9469 to
d1383ac
Compare
rsmmr
approved these changes
Dec 16, 2025
Member
rsmmr
left a comment
rsmmr
left a comment
There was a problem hiding this comment.
Thanks, works for me. I'm not totally sure if there might be other ways for the new validation to fail, but at least I can't come up with anything right now.
In #122 there's spurious stderr output for Spicy's test suite reported. This is due to the new code from #121 eagerly reading all keys in all sections, even if some, like [environment-<tag>] sections for alternatives, would never be used if not selected explicitly. Move the interpolation check below Options.alternative wrangling and skip sections that won't be used. This squelches the spurious stderr output. I've added a test, though it's a bit opaque.
awelzel
force-pushed
the
topic/awelzel/122-skip-non-selected-environment-interpolation
branch
from
e1de2bf to
9e109ac
Compare
awelzel
deleted the
topic/awelzel/122-skip-non-selected-environment-interpolation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #122 there's spurious stderr output for Spicy's test suite reported. This is due to the new code from #121 eagerly reading all keys in all sections, even if some, like [environment-] sections for alternatives, would never be used if not selected explicitly.
Move the interpolation check below Options.alternative wrangling and skip sections that won't be used. This squelches the spurious stderr output. I've added a test, though it's a bit opaque.