d_a_obj_rope_igaiga OK #286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for SOUE01 (df5bd1a - 3bbca85)📈 Matched code: 23.04% (+0.08%, +10628 bytes) ✅ 33 new matches
...and 3 more new matches |
include/d/col/c/c_cc_d.h
Outdated
Comment on lines
1015
to
1017
| void OffCoSet() { | ||
| mCo.OffSPrm(1); | ||
| } |
Collaborator
There was a problem hiding this comment.
there should already be a ClrCoSet inline defined
|
|
||
| dCcD_SrcSph dAcOropeIgaiga_c::sSphSrc = { | ||
| /* mObjInf */ | ||
| {/* mObjAt */ {0x400, 0x1F, {0, 0, 0}, 1, 0, 0, 0, 0, 0}, |
Comment on lines
59
to
62
| inline static void vecCylCalc(mVec3_c &target, const mAng &rot, f32 factor) { | ||
| target.x += factor * rot.sin(); | ||
| target.z += factor * rot.cos(); | ||
| } |
Collaborator
There was a problem hiding this comment.
add to issue comment for notice :)
Collaborator
There was a problem hiding this comment.
With #291 merged this can now be removed and the call replaced with a call to getCirclePoint from d/d_vec.h
| mRotationYOffset = rotationYOffset; | ||
| } | ||
| mLinkPosDiff = mPosition - dAcPy_c::GetLink()->getCenterTranslation(); | ||
| if (dAcPy_c::GetLink()->getCurrentAction() == 0x25 /* (IDL_ON_VINES|NO_STAMINA) */) { |
Collaborator
There was a problem hiding this comment.
This action is not yet known. We know its vine related based on positioning in enum.
Action isnt a bitfield
Contributor
Author
There was a problem hiding this comment.
Yeah I knew it didn't make much sense but it's what ghidra showed so I added the comments in case it could help me understand the code (it didn't) and I forgot to remove them.
|
|
||
| #include "d/a/d_a_base.h" | ||
| #include "d/a/obj/d_a_obj_base.h" | ||
| #include "d/a/obj/d_a_obj_ivy_rope.h" |
Collaborator
There was a problem hiding this comment.
d_a_obj_ivy_rope can be removed from this header.
Instead forward delcare it since its used for a reference
robojumper
reviewed
Dec 21, 2025
| } else if (field_0x91E == 0) { | ||
| deleteRequest(); | ||
| } | ||
| if ((u16)(field_0x91E - 1) <= 1) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ((u16)(field_0x91E - 1) <= 1) { | |
| if (field_0x91E > 0 && field_0x91E < 3) { |
This should work too
swekka
force-pushed
the
d_a_obj_rope_igaiga
branch
from
71eabb6 to
206079e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.