build: namespace the generated version.h
#31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zephyr's build time generated `version.h` is now in the `zephyr` to provide proper namespace, update the includes of this module accordingly. Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
requested review from
dbaluta,
iuliana-prodan,
kv2019i,
lgirdwood and
lyakh
as code owners
|
Shouldn't this be submitted first to https://github.com/thesofproject/sof/ ? |
Member
Author
oops, sorry - https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zephyr's build time generated
version.his now in thezephyrto provide proper namespace, update the includes of this module accordingly.See zephyrproject-rtos/zephyr#63973