drivers: gpio: emul: validate pins in single-pin APIs and mask in port APIs #101440
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvikdesai
force-pushed
the
validate_gpioemul_input_pin
branch
from
36474b6 to
d9cd735
Compare
drivers/gpio/gpio_emul.c
Outdated
Contributor
There was a problem hiding this comment.
NIT: I think this is easier to read and it matches the other checks done in this file.
Suggested change
| if ((config->common.port_pin_mask & mask) == 0) { |
jayvikdesai
force-pushed
the
validate_gpioemul_input_pin
branch
from
d9cd735 to
efcd029
Compare
…t APIs Add input validation to single-pin GPIO APIs (e.g., gpio_pin_configure) and emulator-specific helpers to return -EINVAL for invalid pins. This ensures tests correctly fail when targeting non-existent pins. For standard port-wide APIs (e.g., gpio_port_set_bits_raw), align behavior with hardware drivers by masking out invalid pins instead of returning an error. This mimics hardware behavior where writing to unimplemented bits is ignored, and ensures compatibility with generic tests that use full 32-bit masks (e.g., 0xFFFFFFFF). Signed-off-by: jayvikdesai <[email protected]>
jayvikdesai
force-pushed
the
validate_gpioemul_input_pin
branch
from
efcd029 to
ff49cf7
Compare
|
keith-zephyr
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add input validation to single-pin GPIO APIs (e.g., gpio_pin_configure) and emulator-specific helpers to return -EINVAL for invalid pins. This ensures tests correctly fail when targeting non-existent pins.
For standard port-wide APIs (e.g., gpio_port_set_bits_raw), align behavior with hardware drivers by masking out invalid pins instead of returning an error. This mimics hardware behavior where writing to unimplemented bits is ignored, and ensures compatibility with generic tests that use full 32-bit masks (e.g., 0xFFFFFFFF).