shell: adc_shell: fix read values for 16-bit adcs #101459
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ADC shell was showing incorrect values for ADCs with 16-bit resolution, as the 16th bit was being misinterpreted as the sign bit. This PR aims to fix that by changing the type of the sample buffer to unsigned 16-bit values. Signed-off-by: Alejandro Perea <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ADC shell was showing incorrect values for ADCs with 16-bit resolution, as the 16th bit was being misinterpreted as the sign bit.
This PR aims to fix that by changing the type of the sample buffer to unsigned 16-bit values.