drivers: sdhc: imx_usdhc: add retry for DAT3 card detection #101464
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
JiafeiPan,
Zhiqiang-Hou,
danieldegrasse,
dbaluta,
iuliana-prodan and
yangbolu1991
DAT3-based card detection may fail for the first attempt on RT1060evkc + NXP_IW610x_v1 card, caused by transient signal states during initialization. Add a short retry loop (by default 10 attempts, 1 ms delay) to improve detection reliability. Signed-off-by: Maochen Wang <[email protected]>
MaochenWang1
force-pushed
the
main_mc_usdhc_dat3_retry
branch
from
c6dcb7a to
7faeeca
Compare
|
| /* Default transfer timeout in ms for tuning */ | ||
| #define IMX_USDHC_DEFAULT_TIMEOUT (5000U) | ||
| /* USDHC DAT3 detect attempts */ | ||
| #define IMX_USDHC_DAT3_DETECT_RETRY_MAX (10U) |
Contributor
There was a problem hiding this comment.
Would it make sense to make this a Kconfig, and only set it for boards that need it?
Contributor
There was a problem hiding this comment.
Agree, a Kconfig item for retry count, the default value could be 1, and could be changed by boards
JiafeiPan
requested changes
Dec 24, 2025
| /* Default transfer timeout in ms for tuning */ | ||
| #define IMX_USDHC_DEFAULT_TIMEOUT (5000U) | ||
| /* USDHC DAT3 detect attempts */ | ||
| #define IMX_USDHC_DAT3_DETECT_RETRY_MAX (10U) |
Contributor
There was a problem hiding this comment.
Agree, a Kconfig item for retry count, the default value could be 1, and could be changed by boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAT3-based card detection may fail for the first attempt on RT1060evkc + NXP_IW610x_v1 card, caused by transient signal states during initialization. Add a short retry loop (by default 10 attempts, 1 ms delay) to improve detection reliability.