Skip to content

Conversation

@jro-cw
Copy link

@jro-cw jro-cw commented Jul 6, 2021

<this proposed change makes more sense in split view>
I read a warning in the docs that one could not use both blacklist and whitelist at the same time, ... This is because the blacklist processing overrides the previous whitelist processing. Assuming that blacklist processing should have precedence, that if the address is in both blacklist and whitelist, then the blacklist, as more restrictive, should win.

This proposed change performs the blacklist check first. Then, only if the address is not explicitly denied from the blacklist will the whitelist processing be performed.

There will be no impact to those implementations that have at most one {black|white}list.

I'm sure this pull-request isn't a big deal, as without wildcards most developers would not use both, ... but at least consider processing blacklist first, otherwise the blacklist processing completely undoes a whitelist denial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant