Tests pour le spam_detector #6723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemilink
requested changes
Mar 24, 2025
zds/utils/tests/tests_antispam.py
Outdated
Comment on lines
7
to
29
| """class SpamDetectorTestCase(TestCase): | ||
|
|
||
| @patch('zds.utils.spam_detector.SpamDetector.send_alert') #To avoid sending the actual alert | ||
| def test_check_profile_no_bio(self, mock_send_alert): | ||
| # Create a user profile | ||
| self.user = User.objects.create_user(username="testuser1", password="password") | ||
| self.profile = Profile.objects.create(user=self.user) | ||
|
|
||
| self.spam_detector = SpamDetector() | ||
| #User without a biography | ||
| self.profile.biography = "" | ||
|
|
||
| # Appeler la méthode qui devrait vérifier la biographie de l'utilisateur | ||
| self.spam_detector.check_profile(self.profile) | ||
|
|
||
| # Vérifier que l'alerte n'a pas été envoyée | ||
| mock_send_alert.assert_not_called() | ||
|
|
||
| # Vérifier le message de log | ||
| with self.assertLogs(self.spam_detector.logger, level='INFO') as log: | ||
| self.spam_detector.check_profile(self.profile) | ||
| self.assertIn("∅ testuser has no biography", log.output) | ||
| """ |
Comment on lines
+49
to
+53
| @patch("zds.utils.spam_detector.SpamDetector.send_alert") | ||
| def test_check_profile_no_bio(self, mock_send_alert): | ||
| """User with no biography should not trigger an alert.""" | ||
| self.spam_detector.check_profile(self.profile1) | ||
| mock_send_alert.assert_not_called() |
Member
There was a problem hiding this comment.
Dans les tests de zds-site, on utilise @patch() pour s'assurer que les signaux ont bien été émis, par exemple :
Pour tester ça, on ferait plutôt :
self.spam_detector.check_profile(self.profile1)
self.assertEqual(Alert.objects.all().count(), 0)
philippemilink
requested changes
Mar 31, 2025
Member
There was a problem hiding this comment.
Ce qu'on a dit lors de notre dernière réunion, c'est que pour les tests il ne devrait pas y avoir besoin d'un fichier JSON avec des données, mais qu'on peut générer des fixtures avec du contenu qui est du spam, par exemple :
- Créer 10 profils avec une biographie qui contient du spam (phrase avec un préfixe, par exemple :
factory.fuzzy.FuzzyText(prefix="spam")). Bannir ces profils - Créer 10 profils avec une biographique qui ne contient pas de spam (
factory.fuzzy.FuzzyText(prefix="correct")) - Entraîner le modèle
- Créer un profil avec une biographie et spammeur et un autre profile non spammeur et tester que la prédiction du modèle est correcte.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Écrire les tests pour assurer le bon fonctionnement de spam_detector
Fix #6720Contrôle qualité