[zmarkdown] Allow using custom element for iframes #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Situphen : should I merge this? What has been decided regarding RGPD-compliance? |
Member
|
Hi Stalone, nothing has been decided yet with the team. I'll push this subject and get back to you with an answer ;) |
Member
|
We finally discussed this topic during our technical meeting, and the conclusion is we would be happy with this new feature! I just added it could be enabled/disabled through an option (so we can update zmd in zds-site even if we are not ready in zds-site to handle the consent request), but I see it is already done! So go ahead and merge! (although I didn't test it and we are not ready in zds-site to use this feature). |
StaloneLab
force-pushed
the
gdpr-compliant-frames
branch
from
7450014 to
48e3f1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to ZMarkdown server,
hide_iframes, which will replace alliframeelements byhidden-frameelements, for all iframe providers configured in theremark-iframesconfiguration file.