-
Notifications
You must be signed in to change notification settings - Fork 4
PHP 8.4: Implicitly nullable parameter declarations deprecated #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
What do you think about name of the Types class? |
|
Nice utility class you invented here, please use the |
|
composer.json
Outdated
| "autoload": { | ||
| "psr-4": { | ||
| "PHPUnit\\": "PHPUnit" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent consistency issue: previously space indent was used not tabs, also seems out of place (see it in github browser)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glensc Thank you!
if it's really also needed for zf1 to make it compatible with 5.3-8.4, then perhaps extract it to a separate package, as a standalone repository in the zf1s org |
8952815 to
8fcd0c4
Compare
Fix using Zf1s\Compat\Types
8fcd0c4 to
0742da9
Compare
PHP 8.4: Implicitly nullable parameter declarations deprecated
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Fixes error:
Implicitly marking parameter ? as nullable is deprecated, the explicit nullable type must be used instead
Fix using Zf1s\Compat\Types