Skip to content

Conversation

@carrefinho
Copy link

Check device state before suspension during soft-off to avoid unexpected behavior from incorrectly suspended devices, using the same existing pattern in zmk_pm_suspend_devices.
Fixes high current consumption on XIAO nRF52840 upon wakeup from soft-off, likely caused by the QSPI flash being put in a weird state.

Tested on XIAO nRF52840 and XIAO nRF52840 Plus:

  • Before: 4.6mA current draw after wake from soft-off (requires multiple additional resets to clear)
  • After: Normal 40µA current draw after wake from soft-off.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

Check state of device before suspension to avoid unexpected behavior from incorrectly suspended devices. Fixes high current consumption on XIAO nRF52840 upon wakeup from soft off.
@carrefinho carrefinho requested a review from a team as a code owner October 21, 2025 20:22
@caksoylar caksoylar added the bug Something isn't working label Oct 21, 2025
Copy link

@sigvebh sigvebh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants