Propagate memory space #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenzek
added a commit
to zml/zml
that referenced
this pull request
Sep 18, 2025
CPU buffers behave differently from Cuda/Rocm/TPU buffers, and in particular they are addressable from main memory. This was annoying and prevented us to add some safety checks that weren't valid for CPU. I'm adding a tag to buffers so that we know which target they refer to. Also there is a bug in PJRT unitialized which doesn't respected the memory. I've opened openxla/xla#31292 but in the meantime I've a workaround in ZML that uses the regular .fromHostBuffer. (I've also a patched version of PJRT plugins in zml/pjrt-artifacts#41 but not merged yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in XLA where the memory space isn't fully propagated when creating uninitialized buffers.