- 
                Notifications
    You must be signed in to change notification settings 
- Fork 98
Apply the latest zope.meta templates #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I tried it in the Plone 6.1 core development buildout on Python 3.13, and that was fine.
I made two small suggestions, but they need not hold back a merge, so I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM scrolling through the changes expecting that nearly all of them are automatically generated.
Co-authored-by: Michael Howitz <[email protected]>
Co-authored-by: Michael Howitz <[email protected]>
| The changes are all auto-generated, correct. I used the NOQA instead of making code changes because the code in question was already old, obsolete and unused. I did apply your suggestions, though, thanks! | 
| I have just released ZODB version 6.1. | 
| @dataflake, I'm late to the party but thanks for caring about maintenance. | 
| @navytux If you have any active branches I would volunteer to merge master. | 
This PR brings the current ZODB master branch up to date with the standards we are applying across all zopefoundation packages in terms of supported Python versions and package configuration files.
I realize this is a large PR that contains a lot of cosmetic changes, but since no one has touched ZODB in quite a while that kind of bit rot was bound to happen. There is no point in letting it fall back even further.