Skip to content

Conversation

@mgorny
Copy link

@mgorny mgorny commented Sep 13, 2025

Change the tested "fake" module name from fake to __fake__ to reduce the risk of collisions with real modules. This fixes test failures when the package is tested in a system environment where fake.py package is installed.

  • I signed and returned the Zope Contributor Agreement, and received and accepted an invitation to join a team in the zopefoundation GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Developer guidelines.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

Change the tested "fake" module name from `fake` to `__fake__` to reduce
the risk of collisions with real modules.  This fixes test failures
when the package is tested in a system environment where `fake.py`
package is installed.

Signed-off-by: Michał Górny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant