Sub: added support for WATER_DEPTH MAVLink reporting #31622
+121
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpiciestMayo
force-pushed
the
water_depth
branch
from
76db206 to
9bb87b9
Compare
ES-Alexander
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Hi @SpiciestMayo, thanks for the contribution!
This looks reasonable to me - I'll see if we can get @Williangalvani (the main ArduSub developer) to give it a review as well 🙂
By the way, GitHub has a set of keywords you can use in a PR description, when you're fixing or closing an issue or pull request. As an example, if you put "Fixes #31614" (instead of just the number), then the issue will get closed as completed automatically when your PR is merged :-)
SpiciestMayo
force-pushed
the
water_depth
branch
from
9bb87b9 to
e14d0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31614
It is implemented similarly to this:
#28875