Rename cleanup member fields #108
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
DefaultRequestHandlerModel:m_pop_limit_pctis renamed asm_cleanup_min_occupancy_ratio.m_pop_size_pctis renamed asm_cleanup_ratio.m_pop_limit_sizeis renamed asm_cleanup_min_occupancy.Let me know if you approve these name changes so I move on with the dependencies.
Obvious dependencies:
appmodeldaqsystemtestehn1-daqconfigsNot-very-obvious dependencies:
lbrulibsused inpython/lbrulibs/app_confgen.pywhich looks very old and outdated.dpdklibsused inpython/dpdklibs/reader_confgen.pywhich looks very old and outdated.dfmodulesused intest/config/hdf5write_test_hwmap.data.xmlwhich looks current.dunedaq_conf_readerused insrc/dunedaq_conf_reader/test/test-config.data.xmlandsrc/dunedaq_conf_reader/test/test-config.data.jsonwhich look current.So,
dfmodulesanddunedaq_conf_readerare also dependencies;lbrulibsanddpdklibsare not. Let me know if you disagree.Addresses issue #10
Type of change
Further checks