GH-182 Fix Legacy formatting when user does not have permission #186
Conversation
Summary of ChangesHello @Rollczi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on resolving issues related to legacy formatting, particularly when user permissions are a factor. It streamlines the processing of legacy color and formatting codes by removing redundant pre- and post-processors and consolidating the logic for clearing section symbols directly into the conversion to Adventure components. This ensures that chat formatting correctly respects user permissions and prevents unintended stripping of styles. Additionally, the build environment has been enhanced with common server plugins to facilitate development and testing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the legacy chat formatting logic by removing the MiniMessage pre/post processors and centralizing the conversion and permission checking within the Legacy utility class. This resolves a bug related to wildcard permissions for colors and decorations, making the permission handling more precise. The overall changes improve code clarity and maintainability. I have one suggestion to further enhance the readability of the permission checking logic.
chatformatter-core/src/main/java/com/eternalcode/formatter/legacy/Legacy.java
Show resolved
Hide resolved
| String result = clearSection(input); | ||
| result = HEX_LEGACY_VANILLA_PATTERN.matcher(result).replaceAll(matchResult -> { | ||
| String hexColor = matchResult.group().replace("&x", "").replace("&", ""); | ||
| return "<#" + hexColor + ">"; |
There was a problem hiding this comment.
vLuckyyy
deleted the
GH-182-Fix-Legacy-formatting-when-user-does-not-have-permission
branch
No description provided.