fellou 2.5.16 (new cask)

[yutaIMD]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

[krehel]

Please rework this entire section.

Use arch instead on_* blocks.
The version is not used at all
Implement sha256
The URL's are not acceptable or versioned.

[samford]

What the previous review was getting at it is that any parts of this URL that vary between releases will need to be part of the cask version. In this case, that will likely include "2025-10-31-1859" as well and may include "1.0.16". If you look at other casks, we handle this with a comma-separated version where the first part is the actual version (e.g., 2.5.16,1.0.16,2025-10-31-1859) and interpolate the values in the url like #{version.csv.first}. The livecheck block also has to produce the same version format, so you could parse the values from the resource URL using a regex with capture groups for these distinct parts.

[samford]

As mentioned in previous review for other PRs, this should not rely on the data being in a specific order. Instead, you need to programmatically identify the object that contains data for the macOS release and return arch-specific versions.