Skip to content

fellou 2.5.16 (new cask) #234866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yutaIMD wants to merge 3 commits into from
Closed

fellou 2.5.16 (new cask) #234866

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13ab393
fellou 2.5.16 (new cask)
yutaIMD Nov 2, 2025
8abb2d5
fellou: Use arch instead of on_* blocks
yutaIMD Nov 3, 2025
d3b5d1a
fellou: Use arch instead of on_* blocks
yutaIMD Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions Casks/f/fellou.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
cask "fellou" do
arch arm: "arm64", intel: "x64"

version "2.5.16"
sha256 arm: "879e31bccc618d967f632ccad21cb66bed18c23ed2d311486468c272a025b0d4",
intel: "8296cb4f1a8699a2456224b1955e628c5ba19c510ae7993876770af350f00f30"

url "https://fellou.s3.us-west-1.amazonaws.com/FellouPC/Fellou-CE-1.0.16-#{version}-2025-10-31-1859-#{arch}.dmg",
Copy link
Member

@samford samford Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the previous review was getting at it is that any parts of this URL that vary between releases will need to be part of the cask version. In this case, that will likely include "2025-10-31-1859" as well and may include "1.0.16". If you look at other casks, we handle this with a comma-separated version where the first part is the actual version (e.g., 2.5.16,1.0.16,2025-10-31-1859) and interpolate the values in the url like #{version.csv.first}. The livecheck block also has to produce the same version format, so you could parse the values from the resource URL using a regex with capture groups for these distinct parts.

verified: "fellou.s3.us-west-1.amazonaws.com/FellouPC/"
name "Fellou"
desc "AI-native meeting co-pilot"
homepage "https://fellou.ai/"

livecheck do
url "https://fellou.ai/api/download"
strategy :json do |json|
json.dig("list", 0, "resource")&.map { |r| r["version"] }
Copy link
Member

@samford samford Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in previous review for other PRs, this should not rely on the data being in a specific order. Instead, you need to programmatically identify the object that contains data for the macOS release and return arch-specific versions.

end
end

app "Fellou.app"

zap trash: [
"~/Library/Application Support/Fellou",
"~/Library/Caches/com.fellou.ai",
"~/Library/Caches/com.fellou.ai.ShipIt",
"~/Library/Caches/fellou-updater",
"~/Library/HTTPStorages/com.fellou.ai",
"~/Library/Preferences/com.fellou.ai.plist",
]
end