Skip to content

Conversation

@dabrain34
Copy link
Contributor

Add a logger with level from ERROR to DEBUG

There are 2 different to call logs:

  • LOG_S_DEBUG which is a log with level 4 and acts as std::cout
  • LOG_DEBUG which is a log with level 4 and acts as printf("fmt\n", args);
  • LOG_DEBUG_CAT which is a log with level 4 with a category as string and acts as printf("fmt\n", args);

There are 4 kind of logs:

  • LOG_DEBUG
  • LOG_INFO
  • LOG_WARN
  • LOG_ERROR

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
All committers have signed the CLA.

@dabrain34
Copy link
Contributor Author

@zlatinski

@ceyusa
Copy link

ceyusa commented Mar 27, 2025

IMO loglevel parameter overlaps with verbose one. Perhaps verbose should just enable loglevel to debug, and remove the if (verbose)s

besides that LGTM

@dabrain34 dabrain34 force-pushed the dab_add_logger branch 4 times, most recently from c620f07 to 84a3158 Compare April 25, 2025 11:03
Add a logger with level from ERROR to DEBUG

Signed-off-by: Stéphane Cerveau <[email protected]>
Copy link

@ceyusa ceyusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabrain34
Copy link
Contributor Author

@zlatinski are you okay to merge this now ?

@zlatinski
Copy link
Contributor

I'm okay with this change, but I would like to ask you to wait until we merge VP9 and Intra refresh changes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants