Issue 53567: Improve "Alias" column performance #7152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-nicka
force-pushed
the
fb_alias_perf_53567
branch
from
bf48dbe to
29a8d35
Compare
experiment/src/org/labkey/experiment/api/AliasDisplayColumnFactory.java
Outdated
Show resolved
Hide resolved
labkey-nicka
force-pushed
the
fb_alias_perf_53567
branch
4 times, most recently
from
cee7b80 to
0f0bb96
Compare
| addColumn(to, i); | ||
| else if (to.getFk() instanceof MultiValuedForeignKey) | ||
| else if (to.isMultiValued() || to.getFk() instanceof MultiValuedForeignKey) | ||
| addColumn(to.getName(), i); // pass-through multi-value columns -- converting will stringify a collection |
Contributor
There was a problem hiding this comment.
Hmm, yes ConvertUtils.convert() is bad this way... Maybe, we need to stop using it directly?
labkey-matthewb
approved these changes
Nov 3, 2025
labkey-nicka
force-pushed
the
fb_alias_perf_53567
branch
2 times, most recently
from
1caa7e7 to
a09092d
Compare
labkey-nicka
force-pushed
the
fb_alias_perf_53567
branch
from
a09092d to
bb3a207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 53567 by refactoring the "Alias" column for data classes and sample types away from the traditional multi-value foreign key (MVFK) to an inline join on the values.
Related Pull Requests
Changes
ColumnInfo.isMultiValued()to allow columns to declare they are multi-value. Formerly, everything needed to be an instance ofMultiValueForeignKey.string_agg()and::text. Reduces per item processing.