Skip to content

Conversation

@wbbradley
Copy link
Contributor

Description

Remove the generate-sui-wallet command.

Test plan

CI Pipeline.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)

  • Storage node:
  • Aggregator:
  • Publisher:
  • CLI: Remove support for the walrus generate-sui-wallet ... command. This command was useful for early testing however it is now a distraction and its role can be filled by normal sui CLI tooling.

@wbbradley wbbradley requested a review from mlegner October 27, 2025 20:46
@github-actions
Copy link
Contributor

Warning: This PR modifies the Walrus CLI. Please consider the following:

  • Make sure the changes are backwards compatible. Consider deprecating options before
    removing them.
  • Generally only use long CLI options, not short ones to avoid conflicts in the
    future.
  • If you added new options or features, or modified the behavior, please document the
    changes in the release notes of the PR and update the documentation in the docs/book
    directory.

@wbbradley wbbradley force-pushed the remove-quick-wallet-setup branch from 4e611dd to 570af9d Compare October 27, 2025 20:47
@github-actions
Copy link
Contributor

PR Preview Action v1.6.2

🚀 View preview at
https://MystenLabs.github.io/walrus/pr-preview/pr-2660/

Built to branch gh-pages at 2025-10-27 20:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@wbbradley wbbradley force-pushed the remove-quick-wallet-setup branch from 570af9d to 9084d51 Compare October 27, 2025 20:49
@wbbradley wbbradley force-pushed the remove-quick-wallet-setup branch from 9084d51 to da94d14 Compare October 28, 2025 17:05
@wbbradley wbbradley force-pushed the remove-generate-sui-wallet branch from 4950754 to 4641957 Compare October 28, 2025 17:05
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the command is actually non-functional and cannot be fixed easily, I'd probably keep it, even though we don't advertise it. It's possible some users actually use it in some scripts, and we can avoid breaking those. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants