Implement std::student_t_distribution #6858
Open
+253
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 47m: Pass: 100%/90 | Total: 1d 03h | Max: 1h 49m | Hits: 97%/214468See results here. |
fbusato
approved these changes
Dec 5, 2025
| #endif // no system header | ||
|
|
||
| #include <cuda/std/__cmath/roots.h> | ||
| #include <cuda/std/__limits/numeric_limits.h> |
Contributor
There was a problem hiding this comment.
yes, I would like to see <cuda/std/__limits/numeric_limits.h> instead of <cuda/std/limits> also in the other distributions
| { | ||
| static_assert(__cccl_random_is_valid_urng<_URng>, "URng must meet the UniformRandomBitGenerator requirements"); | ||
| gamma_distribution<result_type> __gd{__p.n() * result_type{.5}, result_type{2}}; | ||
| return __nd_(__g) * cuda::std::sqrt(__p.n() / __gd(__g)); |
Contributor
There was a problem hiding this comment.
Suggested change
| return __nd_(__g) * cuda::std::sqrt(__p.n() / __gd(__g)); | |
| return __nd_(__g) * ::cuda::std::sqrt(__p.n() / __gd(__g)); |
fbusato
requested changes
Dec 5, 2025
Contributor
fbusato
left a comment
fbusato
left a comment
There was a problem hiding this comment.
only the sqrt namespace remains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.