fix: ensure full column span for headless section type in form builder #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuk <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR ensures that headless section types span the full column width in the form builder by adding the ->columnSpanFull() method call to the HEADLESS case in the SectionComponentFactory.
Key Changes:
- Added
->columnSpanFull()method call to theGrid::make(12)forCustomFieldSectionType::HEADLESScase to match the behavior ofSECTIONandFIELDSETtypes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ->label($customFieldSection->name) | ||
| ->columns(12), | ||
| CustomFieldSectionType::HEADLESS => Grid::make(12), | ||
| CustomFieldSectionType::HEADLESS => Grid::make(12)->columnSpanFull(), |
There was a problem hiding this comment.
The HEADLESS case in SectionInfolistsFactory.php (line 27) is missing the ->columnSpanFull() call that was just added here. For consistency, the same fix should be applied there:
CustomFieldSectionType::HEADLESS => Grid::make($customFieldSection->column_span ?? 12)->columnSpanFull(),This ensures both the form builder and infolists factory handle headless sections consistently.
Suggested change
| CustomFieldSectionType::HEADLESS => Grid::make(12)->columnSpanFull(), | |
| CustomFieldSectionType::HEADLESS => Grid::make($customFieldSection->column_span ?? 12)->columnSpanFull(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.