Skip to content

fix: ensure full column span for headless section type in form builder #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManukMinasyan merged 2 commits into from
Dec 5, 2025
Merged

fix: ensure full column span for headless section type in form builder #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97d5fcb
fix: ensure full column span for headless section type in form builder
ManukMinasyan Dec 5, 2025
20d8fe3
Merge branch '2.x' into fix/section-type-rendering
ManukMinasyan Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/dist/custom-fields.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/Filament/Integration/Factories/SectionComponentFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public function create(CustomFieldSection $customFieldSection): Section|Fieldset
->columnSpanFull()
->label($customFieldSection->name)
->columns(12),
CustomFieldSectionType::HEADLESS => Grid::make(12),
CustomFieldSectionType::HEADLESS => Grid::make(12)->columnSpanFull(),
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HEADLESS case in SectionInfolistsFactory.php (line 27) is missing the ->columnSpanFull() call that was just added here. For consistency, the same fix should be applied there:

CustomFieldSectionType::HEADLESS => Grid::make($customFieldSection->column_span ?? 12)->columnSpanFull(),

This ensures both the form builder and infolists factory handle headless sections consistently.

Suggested change
CustomFieldSectionType::HEADLESS => Grid::make(12)->columnSpanFull(),
CustomFieldSectionType::HEADLESS => Grid::make($customFieldSection->column_span ?? 12)->columnSpanFull(),

Copilot uses AI. Check for mistakes.
};
}
}