chore!: removes livechat:removeAllClosedRooms deprecated method
#36931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: e0b11fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughRemoves the server-side Meteor method Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant MeteorServer as Meteor Server
participant LivechatRooms
participant Remover as removeOmnichannelRoom
rect rgb(240,248,255)
note over Client,MeteorServer: Before change
Client->>MeteorServer: DDP call: livechat:removeAllClosedRooms(departmentIds?)
MeteorServer->>MeteorServer: Check permission: remove-closed-livechat-rooms
alt authorized
MeteorServer->>MeteorServer: applyRoomRestrictions → extraQuery
MeteorServer->>LivechatRooms: findClosedRooms(departmentIds, extraQuery)
LivechatRooms-->>MeteorServer: closed room IDs
loop per room
MeteorServer->>Remover: removeOmnichannelRoom(roomId)
Remover-->>MeteorServer: removed
end
MeteorServer-->>Client: return countRemoved
else not authorized
MeteorServer-->>Client: error-not-allowed
end
end
rect rgb(255,245,238)
note over Client,MeteorServer: After change
Client->>MeteorServer: DDP call: livechat:removeAllClosedRooms(...)
MeteorServer-->>Client: method not found / no handler
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.changeset/neat-spoons-cover.md (1)
1-6: Remove remaining client calls to the removed Realtime methodlivechat:removeAllClosedRooms.
- Found references in clients:
- apps/meteor/client/views/omnichannel/directory/chats/ChatsTable/ChatsTableFilter.tsx — line 16: useMethod('livechat:removeAllClosedRooms')
- apps/meteor/client/views/omnichannel/currentChats/FilterByText.tsx — line 84: useMethod('livechat:removeAllClosedRooms')
- Action: remove or replace these calls and update ServerMethods/types, tests, and docs to match the API removal before merging.
🧹 Nitpick comments (1)
.changeset/neat-spoons-cover.md (1)
5-5: Strengthen the BREAKING note and add migration guidance.Call it a “Meteor (DDP) method” for clarity, and provide a short migration note and deprecation reference to help integrators.
Apply:
-Removes deprecated Realtime API method: `livechat:removeAllClosedRooms` +BREAKING: remove deprecated Meteor (DDP) method `livechat:removeAllClosedRooms`. + +Migration: +- Remove any client calls to this method; it no longer exists as of 8.0.0. +- Replace usage with the supported cleanup workflow (e.g., REST/retention APIs or an admin job), and link to docs/changelog. + +Refs: CTZ-58.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/neat-spoons-cover.md(1 hunks)apps/meteor/app/livechat/server/index.ts(0 hunks)apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts(0 hunks)
💤 Files with no reviewable changes (2)
- apps/meteor/app/livechat/server/index.ts
- apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (1)
.changeset/neat-spoons-cover.md (1)
2-2: Verify '@rocket.chat/meteor' is the intended package in .changeset/neat-spoons-cover.mdNo output from the prior script — run these from the repo root and paste outputs so I can confirm the changeset target matches an actual package name:
# show the changeset and config sed -n '1,160p' .changeset/neat-spoons-cover.md || true cat .changeset/config.json || true jq -r '.packages[]?' .changeset/config.json 2>/dev/null || true # list package names tracked in the repo (git) or fallback to find git ls-files -- '**/package.json' -z | xargs -0 -n1 jq -r '.name // empty' | sort -u || true find . -name package.json -not -path '*/node_modules/*' -print0 | xargs -0 -n1 jq -r '.name // empty' | sort -u || true # search repo for the exact package string rg -n --hidden --glob '!node_modules/**' '@rocket\.chat/meteor' || git grep -n '@rocket.chat/meteor' || trueIf the package name is not present in the package.json list or differs from the monorepo's published package, update the changeset to the correct package name used by your publishing workflow.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #36931 +/- ##
==============================================
Coverage 70.24% 70.24%
==============================================
Files 2999 2999
Lines 102301 102301
Branches 18221 18221
==============================================
+ Hits 71861 71864 +3
+ Misses 28576 28569 -7
- Partials 1864 1868 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
force-pushed
the
release-8.0.0
branch
from
f6eaabb to
70fdc50
Compare
juliajforesti
force-pushed
the
chore/v8/CTZ-58
branch
from
c3aa41a to
573d627
Compare
Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: Diego Sampaio <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: juliajforesti <[email protected]>
…1/roles.*` endpoints (#36896)
#36849) Signed-off-by: Abhinav Kumar <[email protected]>
Co-authored-by: Douglas Fabris <[email protected]>
Co-authored-by: Douglas Fabris <[email protected]>
Updates the version of '@rocket.chat/meteor' to major and removes the deprecated method from the Realtime API.
juliajforesti
force-pushed
the
chore/v8/CTZ-58
branch
from
573d627 to
e0b11fe
Compare
juliajforesti
previously approved these changes
Oct 6, 2025
aleksandernsilva
previously approved these changes
Oct 7, 2025
ggazzo
dismissed stale reviews from aleksandernsilva and juliajforesti
The merge-base changed after approval.
ggazzo
force-pushed
the
release-8.0.0
branch
4 times, most recently
from
329ef07 to
8fa1cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR removes the
livechat:removeAllClosedRoomsdeprecated meteor method.Issue(s)
CTZ-58
Steps to test or reproduce
Further comments
Summary by CodeRabbit