-
Notifications
You must be signed in to change notification settings - Fork 3.1k
#63876 Switch back to latest 8.4 and 8.3 images #9746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me after we remove the changes to docker-compose.yml in favor of bundling the .cnf file into the CLI Dockerfile itself.
This makes use of the test containers published to GitHub Container Registry that includes the necessary `.cnf` file now instead.
Problem:
wordpressdevelop/phpand/cliimages. Merging this PR triggered a rebuild of all the images.virtual-mysql-clientin Debian Trixie uses MariaDB 11, whereas Bullseye uses 10.--ssl-verify-server-certflag from false to truessl=0fixes the issue, however WP-CLI uses the--no-defaultsflag forwp dbcommands, which causes this config value to be ignored and the commands to continue to fail. Therefore the--defaultsflag needs to be used when callingwp dbcommands.The re-introduction of the Memcached tests to the test matrices is because the issue that caused those to break was fixed in the recent rebuild of the images. Not strictly related but it does allow us to confirm that Memcached detection is working again.
The failing PHPUnit tests could be detecting a valid bug, they have not yet been investigated. Jorbin noted that Imagick was updated from 6.9 to 7.1.
Trac ticket: https://core.trac.wordpress.org/ticket/63876