Skip to content

Conversation

@johnbillion
Copy link
Member

@johnbillion johnbillion commented Sep 4, 2025

Problem:

  • In Add PHP 8.5 images wpdev-docker-images#172 support for PHP 8.5 was added to the wordpressdevelop/php and /cli images. Merging this PR triggered a rebuild of all the images.
  • The rebuilds caused the upstream PHP images to get updated because they are not pinned. Since the last rebuild, PHP 8.4 and 8.3 got updated from Debian Bullseye to Debian Trixie.
  • virtual-mysql-client in Debian Trixie uses MariaDB 11, whereas Bullseye uses 10.
  • The MariaDB 11.4 client changed the default value of the --ssl-verify-server-cert flag from false to true
  • The container configuration for the local development environment uses the default self-signed certificate that's generated inside the MySQL/MariaDB container when it first starts.
  • Connections from the MariaDB client inside the WP-CLI container started failing as they now attempt to verify the self-signed cert and fail.
  • Instructing the MariaDB client to use ssl=0 fixes the issue, however WP-CLI uses the --no-defaults flag for wp db commands, which causes this config value to be ignored and the commands to continue to fail. Therefore the --defaults flag needs to be used when calling wp db commands.

The re-introduction of the Memcached tests to the test matrices is because the issue that caused those to break was fixed in the recent rebuild of the images. Not strictly related but it does allow us to confirm that Memcached detection is working again.

The failing PHPUnit tests could be detecting a valid bug, they have not yet been investigated. Jorbin noted that Imagick was updated from 6.9 to 7.1.

Trac ticket: https://core.trac.wordpress.org/ticket/63876

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@johnbillion johnbillion changed the title #63876 No SSL 4 U OK #63876 Switch back to latest 8.4 and 8.3 images Sep 4, 2025
@johnbillion johnbillion marked this pull request as ready for review September 4, 2025 19:25
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion, desrosj, sirlouen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me after we remove the changes to docker-compose.yml in favor of bundling the .cnf file into the CLI Dockerfile itself.

This makes use of the test containers published to GitHub Container Registry that includes the necessary `.cnf` file now instead.
@johnbillion
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants