Add path filtering to pull_request events
#191
Conversation
This adds path filtering to the workflow responsible for building test images and publishing them to GitHub Container Registry. Test images don't need to be generated when a pull request will not result in changes to the actual images themselves.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| - 'entrypoint/**' | ||
| - 'images/**' | ||
| - 'templates/workflow.yml-template' | ||
| - '.github/workflows/github-container-registry.yml' |
There was a problem hiding this comment.
I think update.php needs to be in this list too because it gets called in the check-for-changes job, which doesn't actually leave any files that aren't in this list. Am I missing anything?
There was a problem hiding this comment.
Yes, you're correct. My intention was to hopefully avoid building containers for some pull requests when it was not necessary. But I don't think there's much value here after all.
This adds path filtering to the workflow responsible for building test images and publishing them to GitHub Container Registry.
Test images don't need to be generated when a pull request will not result in changes to the actual images themselves.