Skip to content

Add path filtering to pull_request events #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add path filtering to pull_request events #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09d84d8
Add path filtering to `pull_request` events
desrosj Sep 12, 2025
7d7e083
Include workflow template in path filtering
desrosj Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/docker-hub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ on:
- 'config/**'
- 'entrypoint/**'
- 'images/**'
- 'templates/workflow.yml-template'
- '.github/workflows/docker-hub.yml'
workflow_dispatch:
# Once weekly On Sundays at 00:00 UTC.
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/github-container-registry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ name: Build test images

on:
pull_request:
paths:
- 'config/**'
- 'entrypoint/**'
- 'images/**'
- 'templates/workflow.yml-template'
- '.github/workflows/github-container-registry.yml'
workflow_dispatch:

env:
Expand Down
7 changes: 7 additions & 0 deletions templates/workflow.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- 'config/**'
- 'entrypoint/**'
- 'images/**'
- 'templates/workflow.yml-template'
- '.github/workflows/docker-hub.yml'
workflow_dispatch:
# Once weekly On Sundays at 00:00 UTC.
Expand All @@ -28,6 +29,12 @@ name: Build test images

on:
pull_request:
paths:
- 'config/**'
- 'entrypoint/**'
- 'images/**'
- 'templates/workflow.yml-template'
- '.github/workflows/github-container-registry.yml'
Copy link
Member

@johnbillion johnbillion Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think update.php needs to be in this list too because it gets called in the check-for-changes job, which doesn't actually leave any files that aren't in this list. Am I missing anything?

Copy link
Member Author

@desrosj desrosj Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're correct. My intention was to hopefully avoid building containers for some pull requests when it was not necessary. But I don't think there's much value here after all.

workflow_dispatch:

env:
Expand Down
Loading