DOC-18365 Internationalize time #205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnationalize-time # Conflicts: # w_common/pubspec.yaml
abescheideman-wf
changed the title
abescheideman-wf
requested review from
kristleschulz-wk,
lauracallahan-wk and
marshallmoats-wk
kristleschulz-wk
approved these changes
Dec 31, 2025
| fail-fast: false | ||
| matrix: | ||
| sdk: [ 2.19.6, stable ] | ||
| sdk: [ 2.19.6, 3.9.4 ] |
There was a problem hiding this comment.
Is this a CI issue unrelated to your change? What are we downgrading to 3.9.4 here? Will we want to go back and change this to stable at some point?
There was a problem hiding this comment.
Looks like w_common is on an older version 1.4.2 of workiva_analysis_options. So bumping to 1.4.3 should fix as those lint options were removed. Workiva/workiva_analysis_options#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of an effort to internationalize the Document Health panel, let's internationalize our time helper.
See https://workiva.slack.com/archives/CEDM9RH1N/p1767112008311229 for more context.
Changes
Pass our locale to our
Intlmethods so they can be properly formatted.Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: