-
Notifications
You must be signed in to change notification settings - Fork 23
DOC-18365 Internationalize time #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abescheideman-wf
wants to merge
17
commits into
master
Choose a base branch
from
internationalize-time
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−6
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0639ac4
Try internationalizing
abescheideman-wf c9f6a85
local variable
abescheideman-wf f0fa5a7
downgrade ci version
abescheideman-wf 937cca9
use w_intl
abescheideman-wf 313efe4
add version
abescheideman-wf b836320
dont add external dependency
abescheideman-wf c201078
Merge remote-tracking branch 'origin/internationalize-time' into inte…
abescheideman-wf d206e1d
dont add external dependency
abescheideman-wf 3ac6088
upgrade analysis options
abescheideman-wf 57cee43
w_common_tools too
abescheideman-wf 945c72f
follow workiva_analysis_options consumption pattern
abescheideman-wf 0502aa8
wait to pull in latest analysis options
abescheideman-wf 918cc14
define translated strings in a separate file
abescheideman-wf a5f519e
get DateFormat when needed to avoid locale setting race conditions
abescheideman-wf 62b8114
don't depend on w_intl
abescheideman-wf bc61969
format
abescheideman-wf b6a800e
hour minute skeleton
abescheideman-wf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import 'package:intl/intl.dart'; | ||
|
|
||
| class TimeIntl { | ||
| static String get today => Intl.message('Today', name: 'TimeIntl_today'); | ||
|
|
||
| static String get yesterday => | ||
| Intl.message('Yesterday', name: 'TimeIntl_yesterday'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change going to add a space before the AM/PM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will add a space, but we're preferring to adapt to locale now.
