Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang

[nicholasngai]

Description:

storage.googleapis.com/golang no longer allows anonymous bucket access:

Fall back to downloading from dl.google.com/go, which is where https://go.dev/dl/ points to now.

Related issue:

Closes #664.

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[dmitshur]

Consider using https://go.dev/dl/ itself and following the redirects. It's likely that https://dl.google.com/go/ will remain current for a long time, but if it ends up changing in the future, this will break and need updating again. So using https://go.dev/dl/ URLs and following where it redirects should be more future-proof.

[nicholasngai]

Makes sense to me! Just wasn’t sure which would be more stable—I could see an argument that go.dev is unstable too since they could move their download page to a different URL slug so I just chose one arbitrarily.

Updated the PR to do go.dev/dl though!

[nicholasngai]

@dmitshur I also cherry-picked this change onto branches v5, v4, and v3 in #666, #667, and #668 if you don’t mind taking a look!

[dmitshur]

Thanks for doing that!

From my perspective, changing download URLs from https://storage.googleapis.com/golang/{file} to https://go.dev/dl/{file} is the right thing to do, so I'll leave further PR review to owners of this repository.

[nicholasngai]

Oh, whoops, I assumed you were a maintainer. Thanks for the input!

It would be great if this could be merged in rather urgently since this is failing lots of CI checks for us right now.