Skip to content

feat: native build workflow #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

feat: native build workflow #2502

merged 1 commit into from
Nov 3, 2025

Conversation

@bleepbloopsify
Copy link
Contributor

@bleepbloopsify bleepbloopsify commented Oct 7, 2025 •
edited
Loading

added a simple native build + run a single test workflow for ubuntu, 2 node versions, macos, and stuck it all in a matrix

no NIX required

@bleepbloopsify bleepbloopsify force-pushed the leon/native-build branch 3 times, most recently from 8dcc1f3 to 28a4cf2 Compare October 8, 2025 17:59
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 8, 2025

attempting to build this rebased against 2.10.0

@bleepbloopsify bleepbloopsify self-assigned this Oct 8, 2025
@bleepbloopsify bleepbloopsify force-pushed the leon/native-build branch 6 times, most recently from 626e284 to 86927d6 Compare October 13, 2025 14:53
@bleepbloopsify bleepbloopsify changed the base branch from main to leon/bump-mina October 13, 2025 14:53
This was referenced Oct 14, 2025
Merged
Merged
Base automatically changed from leon/bump-mina to develop October 15, 2025 14:21
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 17, 2025 •
edited
Loading

golang versions got dropped from storage.gcloud :(((
waiting for update on setup-go actions before continuing

actions/setup-go#665

using this, check this link to see when it gets merged so we can go back to using official action

@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 21, 2025

spliced in a fork of a setup-go action (its pinned, no supply chain attacks please!)

spliced in an llvm setup for macos benefit (clang is OLD)

@bleepbloopsify bleepbloopsify marked this pull request as ready for review October 21, 2025 20:32
@bleepbloopsify bleepbloopsify requested review from a team as code owners October 21, 2025 20:32
@bleepbloopsify bleepbloopsify requested review from Shigoto-dev19 and hattyhattington17 and removed request for a team October 21, 2025 20:32
@bleepbloopsify bleepbloopsify marked this pull request as draft October 22, 2025 21:23
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 22, 2025

Moving back to draft, because this one is truly a struggle

@bleepbloopsify bleepbloopsify force-pushed the leon/native-build branch 2 times, most recently from 93a01c1 to 9d8061c Compare October 23, 2025 19:42
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 29, 2025

mina didn't respect .cargo/config.toml in proof-systems due to source_tree not respecting dotfiles. I injected a subdir stanza into proof-systems to avoid adding a dune file to their repo, and so we can use .cargo/config.toml

@bleepbloopsify bleepbloopsify force-pushed the leon/native-build branch 2 times, most recently from 1110af7 to dd1310d Compare October 30, 2025 19:35
@bleepbloopsify bleepbloopsify marked this pull request as ready for review October 30, 2025 20:49
@bleepbloopsify bleepbloopsify force-pushed the leon/native-build branch 2 times, most recently from e596d37 to fcad3fa Compare October 31, 2025 15:08
Trivo25
Trivo25 approved these changes Nov 3, 2025
View reviewed changes
.github/workflows/build.yml Outdated

brew link postgresql@15

- name: apt, apt
Copy link
Member

@Trivo25 Trivo25 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt, apt?

Copy link
Contributor Author

@bleepbloopsify bleepbloopsify Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah crap, pop culture

Copy link
Contributor Author

@bleepbloopsify bleepbloopsify Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Shigoto-dev19
Shigoto-dev19 approved these changes Nov 3, 2025
View reviewed changes
.github/workflows/build.yml
ubuntu-latest,
macos-latest,
]
node_version: [22, 24]
Copy link
Contributor

@Shigoto-dev19 Shigoto-dev19 Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only these two versions?

Copy link
Contributor Author

@bleepbloopsify bleepbloopsify Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for node_js, it is because 22 and 24 are both LTS at the moment
nodejS <= 20 breaks o1js and other wasm stuff, so we will no longer use those

@bleepbloopsify bleepbloopsify merged commit 59eba21 into develop Nov 3, 2025
29 checks passed
@bleepbloopsify bleepbloopsify deleted the leon/native-build branch November 3, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@querolita querolita querolita approved these changes

@Trivo25 Trivo25 Trivo25 approved these changes

@Shigoto-dev19 Shigoto-dev19 Shigoto-dev19 approved these changes

Assignees

@bleepbloopsify bleepbloopsify

Labels

no changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bleepbloopsify @querolita @Trivo25 @Shigoto-dev19