Skip to content

Conversation

@yamelsenih
Copy link

Just a minor change for update the sphinx base image to 5.0.2

We are using this change here

Just a minor change for update the sphinx base image to 5.0.2
@adam-grant-hendry
Copy link

adam-grant-hendry commented Oct 18, 2022

@yamelsenih Please do this. For sphinx<4, errors are occurring with deprecated jinja2 imports:

ImportError: cannot import name 'environmentfilter' from 'jinja2'

Updating sphinx in the Docker file should help resolve this. Feel free to reference my Issue #49 for this if you like.

+1

@adam-grant-hendry
Copy link

@ammaraskar Could we update the sphinx base image please?

@watakandai
Copy link

I found a workaround for now.

    - name: Build HTML
      uses: ammaraskar/sphinx-action@master
      with:
        pre-build-command: "pip install 'sphinx==7.1.2' --force-reinstall"
        docs-folder: "docs/"

This should upgrade the sphinx version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants