Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Oct 22, 2025

Rationale for this change

R code duplicated code from C++

What changes are included in this PR?

Remove duplication

Are these changes tested?

There were existing tests

Are there any user-facing changes?

Nah

@github-actions
Copy link

⚠️ GitHub issue #46825 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

⚠️ GitHub issue #46825 has no components, please add labels for components.

@thisisnic thisisnic marked this pull request as ready for review October 22, 2025 11:25
@thisisnic thisisnic requested a review from jonkeane as a code owner October 22, 2025 11:25
@jonkeane
Copy link
Member

@github-actions crossbow submit -g r

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I've triggered a larger run in case there's something off in weird places, but if that passes (or is no worse than main) this is a lovely simplification.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 22, 2025
@github-actions
Copy link

Revision: b003303

Submitted crossbow builds: ursacomputing/crossbow @ actions-753b64161f

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-ubuntu-gcc12-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-focal Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions

@thisisnic
Copy link
Member Author

thisisnic commented Oct 28, 2025

  • test-r-extra-packages is failing because there aren't any relevant nightlies
  • test-r-minimal-build complains about xsimd when building Arrow [1]. Unsure if the function needs it or it's a fluke? I'll retrigger
  • test-r-rocker-r-ver-latest appeared to time out

[1]

In file included from /arrow/cpp/src/arrow/util/bpacking_simd_default.cc:19:
/arrow/cpp/src/arrow/util/bpacking_simd128_generated_internal.h:27:10: fatal error: xsimd/xsimd.hpp: No such file or directory
   27 | #include <xsimd/xsimd.hpp>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/arrow/CMakeFiles/arrow_util.dir/build.make:244: src/arrow/CMakeFiles/arrow_util.dir/util/bpacking_simd_default.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:830: src/arrow/CMakeFiles/arrow_util.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 26%] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/data.cc.o

@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-minimal-build

@github-actions
Copy link

Revision: b003303

Submitted crossbow builds: ursacomputing/crossbow @ actions-c9bb5ed09b

Task Status
test-r-minimal-build Azure

@thisisnic thisisnic force-pushed the GH-46825_smallest_decimal branch from b003303 to daa3173 Compare October 28, 2025 16:50
@thisisnic
Copy link
Member Author

@github-actions crossbow submit -g r

@github-actions
Copy link

Revision: daa3173

Submitted crossbow builds: ursacomputing/crossbow @ actions-23f039f54f

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-ubuntu-gcc12-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-focal Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions

@thisisnic
Copy link
Member Author

OK, this looks good, merging!

@thisisnic thisisnic merged commit 4095d92 into apache:main Oct 28, 2025
9 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants