-
Couldn't load subscription status.
- Fork 3.9k
GH-46825: [R] Use smallest_decimal() from C++ instead of working out which decimal type to instantiate in R #47906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
|
|
@github-actions crossbow submit -g r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I've triggered a larger run in case there's something off in weird places, but if that passes (or is no worse than main) this is a lovely simplification.
|
Revision: b003303 Submitted crossbow builds: ursacomputing/crossbow @ actions-753b64161f |
[1] |
|
@github-actions crossbow submit test-r-minimal-build |
|
Revision: b003303 Submitted crossbow builds: ursacomputing/crossbow @ actions-c9bb5ed09b
|
b003303 to
daa3173
Compare
|
@github-actions crossbow submit -g r |
|
Revision: daa3173 Submitted crossbow builds: ursacomputing/crossbow @ actions-23f039f54f |
|
OK, this looks good, merging! |
Rationale for this change
R code duplicated code from C++
What changes are included in this PR?
Remove duplication
Are these changes tested?
There were existing tests
Are there any user-facing changes?
Nah