CASSANDRA-20982: Restrict BytesType value compatibility to scalar types, exclude collections and UDTs #4439
+94
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BytesType.isValueCompatibleWith() previously accepted all types, including frozen collections and UDTs. This was incorrect because converting collections or UDTs to raw bytes is nonsensical - it allows reading raw serialized bytes which have no meaningful interpretation. This patch restricts BytesType to only accept simple scalar types by checking !isCollection() && !isUDT() in isValueCompatibleWithInternal(). patch by Dekrate for CASSANDRA-20982
smiklosovic
reviewed
Oct 27, 2025
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Oct 27, 2025
Replace isCollection() && isUDT() checks with isMultiCell() for cleaner code. Update error message in AlterTableStatement to more clearly indicate that we're adding a column of incompatible type with a previously dropped column, rather than suggesting the dropped column had the new type. Update tests to match the new error message format. patch by Dekrate for CASSANDRA-20982
|
@smiklosovic, done |
driftx
reviewed
Oct 27, 2025
| return true; | ||
| // BytesType should only be compatible with simple scalar types, not with collections or UDTs | ||
| // because converting a collection or UDT to raw bytes is nonsensical | ||
| return !otherType.isMultiCell(); |
There was a problem hiding this comment.
Doing this here will break cql CAST operations, which I think we still might want to allow since they are explicit, and different from finding a column you re-added contains junk bytes.
Also, isMultiCell will return false for frozen collections.
There was a problem hiding this comment.
@driftx, should I revert to the first version?
return !otherType.isCollection() && !otherType.isUDT();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict BytesType compatibility to scalar types only
BytesType.isValueCompatibleWith() previously accepted all types,
including frozen collections and UDTs. This was incorrect because
converting collections or UDTs to raw bytes is nonsensical - it
allows reading raw serialized bytes which have no meaningful
interpretation.
This patch restricts BytesType to only accept simple scalar types
by checking !isCollection() && !isUDT() in isValueCompatibleWithInternal().
@driftx <- it was your task, I was happy to help!