Skip to content

Conversation

@liujiayi771
Copy link
Contributor

What changes are proposed in this pull request?

Print dlerror() output when dlsym() fails to load function in shared library.

How was this patch tested?

N/A

@github-actions github-actions bot added the VELOX label Oct 27, 2025
const std::string& libPath,
const std::string& func,
bool throwIfNotFound = true) {
dlerror();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a redundant call?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clear the dlerror before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clear the dlerror before.

Got it, thanks.

@liujiayi771 liujiayi771 requested a review from marin-ma October 28, 2025 03:45
@liujiayi771 liujiayi771 merged commit 147ed91 into apache:main Oct 29, 2025
167 of 187 checks passed
@liujiayi771 liujiayi771 deleted the dlsym-error branch October 29, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants