Skip to content

[VL] Add dlerror message for library load failures #10952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

[VL] Add dlerror message for library load failures #10952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
299d5c2
Add dlerror message for library load failures
liujiayi771 Oct 27, 2025
c59a860
Add comments
liujiayi771 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cpp/velox/udf/UdfLoader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,13 @@ void* loadSymFromLibrary(
const std::string& libPath,
const std::string& func,
bool throwIfNotFound = true) {
// Clear any existing dlerror() state before calling dlsym.
dlerror();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a redundant call?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clear the dlerror before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clear the dlerror before.

Got it, thanks.

void* sym = dlsym(handle, func.c_str());
if (!sym && throwIfNotFound) {
throw gluten::GlutenException(func + " not found in " + libPath);
const char* error = dlerror();
throw gluten::GlutenException(
fmt::format("Failed to load {} in {}: {}", func, libPath, error != nullptr ? error : "unknown error"));
}
return sym;
}
Expand Down