Skip to content

Conversation

@vouidaskis
Copy link
Contributor

@vouidaskis vouidaskis commented Apr 3, 2025

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Check if map filter exists to prevent undefined error when loading the search results
If a migration removes the map filter from standard-search-view config the search results are empty and an error is thrown

Issues Solved

Closes #11951

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

@chiatt
Copy link
Member

chiatt commented Apr 4, 2025

@vouidaskis Thanks for submitting this PR. Could you please provide a little more information on how to reproduce this error? Also, for future PRs, could you submit an issue that describes the problem in advance of the PR?

@vouidaskis
Copy link
Contributor Author

@vouidaskis Thanks for submitting this PR. Could you please provide a little more information on how to reproduce this error? Also, for future PRs, could you submit an issue that describes the problem in advance of the PR?

Thanks, i just created an issue explaining this issue

@chiatt chiatt requested review from apeters June 12, 2025 23:21
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the changelog entry to the latest release notes?

if (ko.unwrap(this.mapFilter.map)) {
this.mapFilter.map().resize();
//Check if exist the map filter
if (this.mapFilter !== null){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be safer just to check if this.mapFilter has any value rather than specifically for null.

Suggested change
if (this.mapFilter !== null){
if (this.mapFilter){

Copy link
Member

@apeters apeters Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this comment in the release notes to 7.6.13.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants