-
Notifications
You must be signed in to change notification settings - Fork 158
Add Check for map filter in search-results #11917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/7.6.x
Are you sure you want to change the base?
Conversation
|
@vouidaskis Thanks for submitting this PR. Could you please provide a little more information on how to reproduce this error? Also, for future PRs, could you submit an issue that describes the problem in advance of the PR? |
Thanks, i just created an issue explaining this issue |
chiatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the changelog entry to the latest release notes?
| if (ko.unwrap(this.mapFilter.map)) { | ||
| this.mapFilter.map().resize(); | ||
| //Check if exist the map filter | ||
| if (this.mapFilter !== null){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be safer just to check if this.mapFilter has any value rather than specifically for null.
| if (this.mapFilter !== null){ | |
| if (this.mapFilter){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this comment in the release notes to 7.6.13.md
Types of changes
Description of Change
Check if map filter exists to prevent undefined error when loading the search results
If a migration removes the map filter from standard-search-view config the search results are empty and an error is thrown
Issues Solved
Closes #11951
Checklist