Skip to content

Add Check for map filter in search-results #11917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vouidaskis wants to merge 3 commits into
base: dev/7.6.x
Choose a base branch
from
+15 −11
Open

Add Check for map filter in search-results #11917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f48f89
check if exist map filter type
vouidaskis Apr 2, 2025
4bab6ee
small change
vouidaskis Apr 3, 2025
a90ff82
update change log
vouidaskis Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions arches/app/media/js/views/components/search/search-results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,21 @@ define([
this.restoreState();

this.mapFilter = this.getFilterByType("map-filter-type", false);
this.mapFilter.subscribe(mapFilter => {
if (mapFilter) {
this.mapFilter = mapFilter;
}
}, this);
this.selectedTab.subscribe(function (tab) {
if (tab === "map-filter-type") {
if (ko.unwrap(this.mapFilter.map)) {
this.mapFilter.map().resize();
//Check if exist the map filter
if (this.mapFilter !== null){
Copy link
Member

@chiatt chiatt Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be safer just to check if this.mapFilter has any value rather than specifically for null.

Suggested change
if (this.mapFilter !== null){
if (this.mapFilter){

this.mapFilter.subscribe(mapFilter => {
if (mapFilter) {
this.mapFilter = mapFilter;
}
}
}, this);
}, this);
this.selectedTab.subscribe(function (tab) {
if (tab === "map-filter-type") {
if (ko.unwrap(this.mapFilter.map)) {
this.mapFilter.map().resize();
}
}
}, this);
}

this.bulkResourceReportCache = ko.observable({});
this.bulkDisambiguatedResourceInstanceCache = ko.observable({});
Expand Down
1 change: 1 addition & 0 deletions releases/7.6.8.md
View file
Open in desktop
Copy link
Member

@apeters apeters Jun 20, 2025 •
edited by chiatt
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this comment in the release notes to 7.6.13.md

Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Fix severe performance issue in related resource view [#11885](https://github.com/archesproject/arches/issues/11885)
- Fix sorting concepts with special floats [#11790](https://github.com/archesproject/arches/pull/11790)
- Accept `datetime.date` objects in date datatype [#11895](https://github.com/archesproject/arches/issues/11895)
- Fixed error in search results when map filter is not present [#11917](https://github.com/archesproject/arches/pull/11917)

### Dependency changes:

Expand Down