-
Notifications
You must be signed in to change notification settings - Fork 925
[PM-14880] Add pull-request trigger to PR Labeling workflow and address test findings #6305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @vvolkgang's task in 2m 40s —— View job Overall Assessment: APPROVE This PR adds pull-request triggers to the labeling workflow and makes several quality-of-life improvements including consolidated environment variables, improved logging with appropriate severity levels, a catch-all category for release notes, and fixes the FIDO2 privileged file path matching that was introduced in PR #6304. Code Review DetailsNo issues found. All changes are correct and well-implemented:
🚢 Approved - Ready to merge |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6305 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 762 762
Lines 54536 54536
Branches 7833 7833
=======================================
Hits 46636 46636
Misses 5183 5183
Partials 2717 2717 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |

🎟️ Tracking
PM-14880
📔 Objective
Adds pull-request trigger to sdlc-label-pr.yml and addresses the following bits found while testing:
release.yml- handles the transition period when most PRs won't have accurate labels and if we later decide to remove addingt:miscas a fallback inlabel-pr.pyTest Runs:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes