Skip to content

Conversation

@vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Dec 29, 2025

🎟️ Tracking

PM-14880

📔 Objective

Adds pull-request trigger to sdlc-label-pr.yml and addresses the following bits found while testing:

  1. Consolidate PR Number env var in sdlc-label-pr.yml
  2. Logging - Reduced copy and replaced GitHub summary warnings with notices for informative logs and removes
  3. Add catch-all category to release.yml - handles the transition period when most PRs won't have accurate labels and if we later decide to remove adding t:misc as a fallback in label-pr.py
  4. Fixes the labeling of PRs changing FIDO2 Privileged lists, introduced in [PM-14880] Label updates to fido2 privileged apps lists #6304

Test Runs:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner December 29, 2025 22:09
@github-actions github-actions bot added the t:ci Change Type - Updates to automated workflows label Dec 29, 2025
@vvolkgang vvolkgang added ai-review Request a Claude code review and removed t:ci Change Type - Updates to automated workflows labels Dec 29, 2025
@claude
Copy link
Contributor

claude bot commented Dec 29, 2025

Claude finished @vvolkgang's task in 2m 40s —— View job


Overall Assessment: APPROVE

This PR adds pull-request triggers to the labeling workflow and makes several quality-of-life improvements including consolidated environment variables, improved logging with appropriate severity levels, a catch-all category for release notes, and fixes the FIDO2 privileged file path matching that was introduced in PR #6304.

Code Review Details

No issues found. All changes are correct and well-implemented:

  • FIDO2 path fix - Correctly updates paths to full app/src/main/assets/ prefix (verified files exist at these locations)
  • Workflow consolidation - _PR_NUMBER properly moved to workflow-level env, correctly handles both pull_request and workflow_dispatch triggers
  • Logging improvements - Appropriately downgrades informational messages from ::warning:: to ::notice::, maintains ::warning:: for actual issues
  • Release.yml catch-all - Wildcard '*' correctly placed as final item in Maintenance category to handle transition period
  • JSON/YAML syntax - All configuration files are valid

🚢 Approved - Ready to merge

@github-actions github-actions bot added t:ci Change Type - Updates to automated workflows and removed ai-review Request a Claude code review labels Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.51%. Comparing base (ebed1bd) to head (81e96b4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6305   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files         762      762           
  Lines       54536    54536           
  Branches     7833     7833           
=======================================
  Hits        46636    46636           
  Misses       5183     5183           
  Partials     2717     2717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8ebe960a-ac47-4a00-aa56-508f9d55a340

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang added this pull request to the merge queue Dec 30, 2025
Merged via the queue into main with commit d98e459 Dec 30, 2025
18 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/improve-labels branch December 30, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants