fix exception when using jsonprocessor and mode :while_needs_response #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 26, 2025 16:37
… can happen when there is a single message from llm call that requests a tool call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was running into failure when using mode :while_needs_response and using message_processors with JsonProcessor. the run_while_needs_response/1 would call do_run/1 then get a single message response and call process_message/2 which calls run_message_processors/2 but the message.content is nil because its a tool call message.
we would then fail at:
message = %Message{message | processed_content: ContentPart.parts_to_string(message.content)}
when we try to call parts_to_string/1 which expects to get a list instead of nil
perhaps another solution is to add
ContentPart.parts_to_string(nil) -> nil