Skip to content

fix exception when using jsonprocessor and mode :while_needs_response #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ellyxir wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix exception when using jsonprocessor and mode :while_needs_response #303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad8b994
output failed original message when we cant find json
Apr 26, 2025
5c1c909
do not run message processors if there is no content to process. this…
May 2, 2025
5303d5b
remove debugging
May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/chains/llm_chain.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,9 +888,9 @@ defmodule LangChain.Chains.LLMChain do
Message.t() | {:halted, Message.t(), Message.t()}
def run_message_processors(
%LLMChain{message_processors: processors} = chain,
%Message{role: :assistant} = message
%Message{role: :assistant, content: message_content} = message
)
when is_list(processors) and processors != [] do
when is_list(processors) and processors != [] and is_list(message_content) and message_content != [] do
# start `processed_content` with the message's content as a string
message = %Message{message | processed_content: ContentPart.parts_to_string(message.content)}

Expand Down Expand Up @@ -919,7 +919,7 @@ defmodule LangChain.Chains.LLMChain do
end)
end

# the message is not an assistant message. Skip message processing.
# the message is not an assistant message or there is no content to process. Skip message processing.
def run_message_processors(%LLMChain{} = _chain, %Message{} = message) do
message
end
Expand Down