Update CODEOWNERS to initialize vi l10n #3460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junya Okabe <[email protected]>
Okabe-Junya
requested review from
caniszczyk,
iamNoah1,
jihoon-seo,
nate-double-u and
seokho-son
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Okabe-Junya
added
the
maintainers
nate-double-u
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Thanks for setting this up @Okabe-Junya.
Welcome to the Glossarry @ntheanh201 @thuanpham582002!
|
Welcome @ntheanh201 @thuanpham582002! |
|
Thanks @jihoon-seo |
Signed-off-by: Junya Okabe <[email protected]>
2 tasks
|
Hi @Okabe-Junya Please update this PR according to the consensus here. #3458 (comment) |
Signed-off-by: Junya Okabe <[email protected]>
|
Thank you for letting me know, @seokho-son!! I have updated in 417db46, so please take a look again, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related issue number or link (ex:
resolves #issue-number)ref. #3458
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".