Fix flaky timing assertions in waitForCondition tests #9230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust timing thresholds to account for CI environment variations: - Allow 90ms instead of strict 100ms for multi-interval waits - Allow 140ms instead of 150ms for setTimeout-based tests - Maintain reasonable upper bounds to catch actual issues This addresses test failures seen in CI where timing can vary by a few milliseconds. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <[email protected]> Co-authored-by: nate <[email protected]>
dosubot
bot
added
the
size:S
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes flaky timing assertions in the
TUIChat.waitForCondition.test.tsfile that were causing CI failures in PR #9227.Changes
Adjusted timing thresholds to account for CI environment variations:
Issue
The tests were failing intermittently in CI with errors like:
This happens because setTimeout and timing operations can complete a few milliseconds earlier or later than expected, especially in CI environments under load.
Testing
These changes maintain test effectiveness while being more tolerant of normal timing variations. The upper bounds ensure we still catch real performance issues.
This agent session was co-authored by nate and Continue.
Summary by cubic
Relaxed lower-bound timing checks in TUIChat.waitForCondition tests to stop flaky CI failures. Keeps strict upper bounds so real timing regressions still fail.
Written for commit 9a129b0. Summary will update automatically on new commits.