Skip to content

Fix flaky timing assertions in waitForCondition tests #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
continue wants to merge 1 commit into
base: improved-tests-for-pr-9111
Choose a base branch
from
+6 −4
Open

Fix flaky timing assertions in waitForCondition tests #9230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions extensions/cli/src/ui/__tests__/TUIChat.waitForCondition.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ describe("waitForCondition utility function", () => {

const elapsed = Date.now() - startTime;

// Should have waited for at least 2 intervals (100ms)
expect(elapsed).toBeGreaterThanOrEqual(100);
// Should have waited for at least 2 intervals (~100ms, allow 90ms for timing variations)
expect(elapsed).toBeGreaterThanOrEqual(90);
expect(counter).toBeGreaterThanOrEqual(3);
});

Expand Down Expand Up @@ -178,8 +178,9 @@ describe("waitForCondition utility function", () => {
const elapsed = Date.now() - startTime;

// Should return shortly after 100ms, not wait full timeout
// Allow for timing variations (90ms-500ms is reasonable)
expect(elapsed).toBeGreaterThanOrEqual(90);
expect(elapsed).toBeLessThan(500);
expect(elapsed).toBeGreaterThanOrEqual(100);
});
});

Expand Down Expand Up @@ -222,7 +223,8 @@ describe("waitForCondition utility function", () => {
const elapsed = Date.now() - startTime;

expect(frameContent).toBe("Updated content");
expect(elapsed).toBeGreaterThanOrEqual(150);
// Allow for timing variations (140ms-500ms is reasonable)
expect(elapsed).toBeGreaterThanOrEqual(140);
expect(elapsed).toBeLessThan(500);
});

Expand Down
Loading