refined format, code, documentation related to coprocessor generator #296
Conversation
Joonari
left a comment
Joonari
left a comment
There was a problem hiding this comment.
Some minor style issues.
openasip/src/applibs/HWGen/FUGen.cc
Outdated
| oredsignalsR = oredsignals; | ||
| BitwiseOr bitwiseOred(bitwiseAnded, andedSignals); | ||
| andedSignals = bitwiseOred; | ||
| oredSignalsR = bitwiseOred; |
There was a problem hiding this comment.
What the R stand for in oredSignalsR? It should be expanded.
| /** | ||
| * BEM constructor for the Coprocessor generation. | ||
| * Overloaded BEM constructor related to CV-X-If and ROCC coprocessor generation. | ||
| * RISCV instrucion encodings are created based on the coproInterF boolean. |
There was a problem hiding this comment.
The F in the boolean name mentioned here should also be expanded for consistent style.
|
fixed the style issues mentioned by @Joonari |
|
Why doesn't it recognize the CI workflow? Is this rebased on the latest main? |
|
Ah, this is a merge request to the other branch. Please just rebase on it and then rebase on main to submit a PR towards main. |
|
Added updates in CHANGES and fixed the issues pointed by @pjaaskel |
|
Please just rebase on the other branch and then rebase on main and submit a PR towards main instead to the other PR. |
|
LGTM after you send a PR against the main branch. |
3 participants
fixed issues in format, comments, code , documenatation related to coprocessor-generator